Adapt the accuracy constant types with the accuracy parameter used to get the position#1646
Adapt the accuracy constant types with the accuracy parameter used to get the position#1646HeropolisDa2ny wants to merge 1 commit intotransistorsoft:masterfrom
Conversation
… position (getCurrentPosition)
|
Hi @christocracy Do you prefer we create issues instead of PR ? |
|
The desiredAccuracy for getCurrentPosition doesn't have the same meaning as that given to GeoConfig. GeoConfig.desiredAccuracy: the actual desiredAccuracy to define power level of location API CurrentPositionRequest.desiredAccuracy: a mere threshold of accuracy satisfaction. When a location arrives having good enough accuracy, the request stops damping and returns the best so far. .getCurrentPosition always uses full power. |
|
Giving a value of DesiredAccuracy.high to getCurrentPosition defeats the purpose of this threshold since that would define an unattainable threshold of The minimum attainable geolocation accuracy is ~5 meters. |
|
with getCurrentPosition, both
|
The desiredAccuracy parameter has been moved to a type double on the newest versions which requires to .toDouble() your constants. Maybe either switch the desiredAccuracy to a integer if possible otherwise define the desiredAccuracy constants doubles ?